fix fd parsing unquoted attribute values #4662
Merged
+252
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Nov 8, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4662 +/- ##
==========================================
- Coverage 92.87% 92.87% -0.01%
==========================================
Files 106 106
Lines 33272 33354 +82
==========================================
+ Hits 30902 30976 +74
- Misses 2370 2378 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uzlopak
reviewed
Nov 8, 2025
Uzlopak
reviewed
Nov 8, 2025
mcollina
reviewed
Nov 8, 2025
Member
Author
|
Can we land this...? It's a bug fix. I don't know why I'm being asked to microoptimize everything. |
tsctx
approved these changes
Nov 9, 2025
Member
Author
|
this seems to have fixed #4661 as well, great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4660
claude did ~half of this PR so be wary